Skip to content

Conversation

@pyropy
Copy link
Member

@pyropy pyropy commented Dec 17, 2024

@pyropy pyropy self-assigned this Dec 17, 2024
@pyropy pyropy marked this pull request as ready for review December 17, 2024 10:29
@pyropy pyropy marked this pull request as draft December 17, 2024 11:32
@pyropy pyropy changed the title Add cloudflare account id to deployment Fix deployment Dec 17, 2024
@pyropy pyropy marked this pull request as ready for review December 17, 2024 11:44
@pyropy pyropy requested a review from juliangruber December 17, 2024 13:22
package.json Outdated
"main": "index.js",
"scripts": {
"deploy": "wrangler deploy",
"deploy": "wrangler deploy --env dev",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why dev env?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If environment is not specified it will deploy to default environment. Since we have environment production defined, I thought it might be good to be explicit here. I can roll it back if you want.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But why would we deploy to the dev environment? Shouldn't we deploy to production? I would expect nom run deploy to do that. If you specifically want to deploy to dev, what about renaming the script to "deploy:dev"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found it useful to deploy during the development as many things like cache are not available out of the box. I do agree that the name might be a little off -- I'm renaming the script to deploy:dev and deploy:prod to deploy.

@pyropy pyropy merged commit 1835c06 into main Dec 17, 2024
2 checks passed
@pyropy pyropy deleted the fix-deployment branch December 17, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automate testing and deployment using Github Actions

3 participants